[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use apr-util's expat

From: Christian Schaffner <schaffner_at_eeh.ee.ethz.ch>
Date: 2002-04-16 15:08:43 CEST

At 7:48 Uhr -0400 16.4.2002, Garrett Rooney wrote:
>On Tue, Apr 16, 2002 at 12:48:37AM -0700, Justin Erenkrantz wrote:
>> This patch switches us to using apr-util's detected expat.
>>
>> 'make check' succeeded with installed expat-1.95.2.
>>
>> Thoughts? This should allow us to remove expat-lite from our
>> tree and rely on apr-util either finding an installed expat
>> or using its bundled expat.
>
>i haven't given this a close review, but in concept i'm +1. i already
>have to hack build.conf for the FreeBSD port to get it to use the
>correct expat, and the rpm's are done the same way, so this would siplify
>things greatly for those two cases.

I applied this patch for the fink package on MacOS X (using the
r1682+ tarbal) and it seems to work fine. If this could be included
into the subversion source tree I wouldn't need to patch anymore for
building a package using the installed expat libraries (version of
expat: 1.95.1).

The only thing that seems different are a few warning messages similar to:

In file included from apr_xml.c:69:
/sw/include/expat.h:706: warning: function declaration isn't a prototype

Is this a problem?

Chris.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 16 15:09:45 2002

This is an archived mail posted to the Subversion Dev mailing list.