Re: rMacOS X: Test failure with r1682+

Karl Fogel wrote:
>
> Ben Collins-Sussman <sussman@collab.net> writes:
> > Actually, this is a 'feature' that was added to our tarball-generating
> > script (dist.sh). It patches svn_version.h to include the exact
> > revision number of the tarball, whereas normally the value is just the
> > string "dev build". IIRC, this was added as a way of knowing whether
> > somebody was using a client built from tarball, or if they're using
> > HEAD. Just run 'svn --version' and see.
> >
> > Of course, I guess this means that 'make check' won't work for a
> > tarball build. Unless, of course, we patch getopt_tests.py in the
> > tarball as well. :-)
>
> Whoa. That's ridiculous -- the tarballs need to pass 'make check'. :-)
>
> Blair, can you review my fix in revision 1717? Thanks.
>
> -K

The fix looks fine.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org