[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: cvs2svn.py patch

From: Sander Striker <striker_at_apache.org>
Date: 2002-04-14 11:48:43 CEST

> From: misiek@arm.t19.ds.pwr.wroc.pl [mailto:misiek@arm.t19.ds.pwr.wroc.pl]On Behalf Of Arkadiusz Miskiewicz
> Sent: 14 April 2002 11:28

> Hi,
>
> cvs2svn.py doesn't work if there are filenames with special
> shell meaning like ,,('' etc.
>
> --- .SVN-OTHER/subversion/tools/cvs2svn/cvs2svn.py Tue Apr 9 02:31:06 2002
> +++ cvs2svn.py Sun Apr 14 11:23:33 2002
> @@ -359,7 +360,7 @@
> f = os.path.join(dirname, 'Attic', fname)
> statcache.stat(f)
>
> - pipe = os.popen('co -q -p%s %s' % (r, f), 'r', 102400)
> + pipe = os.popen('co -q -p%s \'%s\'' % (r, f), 'r', 102400)
>
> # if we just made the file, we can send it in one big hunk, rather
> # than streaming it in.
> @@ -377,7 +378,7 @@
> # revision from co, or else the delta won't be correct because
> # the contents in the repo won't have changed yet.
> if repos_path == lastcommit[0]:
> - infile2 = os.popen("co -q -p%s %s" % (lastcommit[1], f), "r", 102400)
> + infile2 = os.popen("co -q -p%s \'%s\'" % (lastcommit[1], f), "r", 102400)
> stream1 = util.svn_stream_from_stdio(infile2, f_pool)
> else:
> stream1 = fs.file_contents(root, repos_path, f_pool)
[...]

Committed, thanks.

Could you do me a favor? Please read the HACKING file and submit
your next patch as described in there ;)

Thanks,

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 14 11:42:15 2002

This is an archived mail posted to the Subversion Dev mailing list.