[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1662 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-04-11 00:04:04 CEST

On Wed, Apr 10, 2002 at 12:29:29AM -0500, kfogel@tigris.org wrote:
>...
> * subversion/include/svn_io.h
> (svn_io__filesizes_different_p): Replaces formerly static function
> filesizes_definitely_different_p, but now takes `const char *'
> instead of `svn_stringbuf_t *'. All callers changed.
>
> * subversion/libsvn_subr/io.c
> (svn_io__filesizes_different_p): Code from questions.c, see above.

That is part of the public interface, so it shouldn't have two underscores
after the "svn_io" portion.

>...
> +++ trunk/subversion/libsvn_wc/questions.h Wed Apr 10 00:29:12 2002
>...
> + * history and logs, available at http://subversion.tigris.org/.
> + * ====================================================================
> + */
> +
> +
> +#include <apr_pools.h>
> +#include "svn_types.h"
> +#include "svn_string.h"
> +#include "svn_error.h"

Even private headers must have guards and the C++ stuff.

>...
> +++ trunk/subversion/libsvn_wc/translate.h Wed Apr 10 00:29:12 2002

Same.

>...
> +++ trunk/subversion/libsvn_wc/props.h Wed Apr 10 00:29:13 2002

Same.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 11 00:04:45 2002

This is an archived mail posted to the Subversion Dev mailing list.