[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 1649 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

From: Sander Striker <striker_at_apache.org>
Date: 2002-04-08 20:29:44 CEST

> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: 08 April 2002 20:13

> On Mon, Apr 08, 2002 at 11:43:58AM -0500, cmpilato@collab.net wrote:
> > <<Removed svn@subversion.collab.net from the Cc: list>>
> >
> > > I'm with Ben here.
> >
> > For what it's worth, I'm with Ben, too, so long as we have a config
> > option for disabling pop-up editors. If that is in place, I'm fine
> > with VI/NOTEPAD as defaults (though I really think they should be in
> > the svn_private_configs.h/.hw files as a compile time #define,
> > something like SVN_DEFAULT_TEXT_EDITOR or something).
>
> Wouldn't /bin/false be a good way to disable the functionality? It will
> return a failure, so we get the whole "abort" thing. Maybe that still isn't
> quite nice enough, so an "editor = no" option might be possible.

An "editor = no" option is the cleanest way to do it IMO. At least
the user will think of this. I don't want to document: "if you don't
want an editor popping up, edit your shell profile by adding a line
like: export SVN_EDITOR=/bin/false". Seems a bit silly.
 
> Cheers,
> -g

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 8 20:24:34 2002

This is an archived mail posted to the Subversion Dev mailing list.