[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1621

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-04-03 22:23:46 CEST

On Wed, Apr 03, 2002 at 12:49:16AM -0600, Karl Fogel wrote:
>...
> Sorry, don't mean to come off like a hard-ass, I'm just not clear on
> the reasoning behind committing this before it's (apparently) ready.
> Are there special circumstances that make this the least painful
> course of action?

Two alternatives were present:

1) check in some work that is still small enough to be reviewable, but the
   tests will be broken until part two arrives. when that does, it will be
   reviewable, too.

2) hold off, continue merging other work, then drop in an unreviewable
   widespread change to svn. "but the tests work!"

Relying on testing _rather_than_review_ is an incorrect pattern of behavior.
When reviewing, the brain looks a TON more stuff than a test does. And at
some point, those tests will return, and we'll get a second pass on the
work. It's just time-shifted is all.

In this case, Mike's checkin gives us something that is still somewhat
grokkable, so it can be reviewed.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 3 22:20:16 2002

This is an archived mail posted to the Subversion Dev mailing list.