[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 1611 - trunk trunk/subversion/mod_dav_svn

From: Sander Striker <striker_at_apache.org>
Date: 2002-04-01 11:11:54 CEST

> From: bcollins@tigris.org [mailto:bcollins@tigris.org]
> Sent: 01 April 2002 01:14

> Author: bcollins
> Date: 2002-03-31 23:13 GMT
> New Revision: 1611
>
> Modified:
> trunk/CHANGES
> trunk/subversion/mod_dav_svn/dav_svn.h
> trunk/subversion/mod_dav_svn/mod_dav_svn.c
> trunk/subversion/mod_dav_svn/repos.c
> Log:
> "Please pass the cheese diff". Simple little feature patch for a
> SVNRepoName directive in mod_dav_svn. I have several repos on one server,
> and it's nice to have a descriptive name when browsing it.

If this is a usefull feature, can we name the directive SVNReposName?
We use the 'repos' shorthand about everywhere afaict and I'd like to stay
consistent.
 
> * mod_dav_svn/dav_svn.h
>
> (dav_svn_dir_conf): Add repo_name member.
>
> (dav_svn_repo_name)(dav_svn_get_repo_name): New functions to pass the
> repository name from the configuration.

You forgot to actually declare dav_svn_get_repo_name.
dav_svn_repo_name is static, so that doesn't belong in the header (it isn't
in there, but is in the commit msg).
 
> * mod_dav_svn/dav_svn.h
>
> (dav_svn_repos): Add repo_name member.
>
> * mod_dav_svn/mod_dav_svn.c:
>
> (dav_svn_get_resource): Prepend SVNRepoName to the "Revision" line, if
> present in the per-repo config.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 1 11:07:06 2002

This is an archived mail posted to the Subversion Dev mailing list.