Re: svn commit: rev 1581 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client
From: Greg Stein <gstein_at_lyra.org>
Date: 2002-03-26 22:43:25 CET
On Thu, Mar 21, 2002 at 08:09:00PM -0600, cmpilato@tigris.org wrote:
Could this whole loop be replaced with svn_path_decompose() ?
>...
Might want to use 'sizeof(*new_baton)'
> + new_baton->path = apr_pstrdup (pool, path);
That cast isn't needed. The cast to 'void *' is automatic.
>...
Since the path can't be changed in the baton (it's const), then can't you
(of course, the make_baton() will be needed if you're going to put something
>...
We might want to avoid variable names that are C++ keywords.
Cheers,
-- Greg Stein, http://www.lyra.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org For additional commands, e-mail: dev-help@subversion.tigris.orgReceived on Tue Mar 26 22:40:05 2002 |
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.