Re: svn commit: rev 1562 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/svnlook trunk/subversion/libsvn_repos

Greg Stein <gstein@lyra.org> writes:
> You're missing what my original comment was:
>
> "The 'npath' variable isn't needed. Just use the 'path' parameter."

And that doesn't sound to you like "You can eliminate the `npath'
variable." ? :-)

> I didn't suggest a prototype change.

Hm, I think I finally understand what's going on here. Your comment
can be interpreted in two ways:

   "You don't need an `npath' variable in that function at all."

versus

   "You don't need to use the `npath' variable for the call to
   svn_io_check_path(), although it may be needed elsewhere in the
   function."

The former being false (unless prototypes change), the latter being
true. I interpreted you as saying the former; which seems the most
natural interpretation of the actual words, frankly. :-(

> it
> seemed you hadn't even taken a moment to actually look at the code which I
> commented on. If you had, you would see it was just that: a simple
> replacement.

Uh, in the future, you might want to consider the possibility that a
phrasing was ambiguous before you turn to the possibility that I'm
discussing a block of code at length without carefully reading it. :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 20 15:57:01 2002