[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1563 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/clients/cmdline trunk/subversion/libsvn_ra_dav

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-03-20 02:22:47 CET

kfogel@tigris.org wrote:

>Author: kfogel
>Date: 2002-03-20 00:51 GMT
>New Revision: 1563
>
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/include/svn_config.h
> trunk/subversion/libsvn_ra_dav/session.c
> trunk/subversion/libsvn_subr/config.c
> trunk/subversion/libsvn_subr/config_file.c
> trunk/subversion/libsvn_subr/config_impl.h
> trunk/subversion/libsvn_subr/svn_string.c
>Log:
>Get proxy information from the user's configuration. Also, ensure
>that the user has at least a template configuration area.
>
I don't understand this change at all. Why do you want to *create* the
~/.subversion dir? It's not as if we'll store any state there, we just
read stuff if it happens to be there.

>* subversion/libsvn_ra_dav/session.c: Include apr_fnmatch.h,
> svn_config.h.
> (get_proxy): New function.
> (search_groups, struct search_groups_baton): New function/baton pair.
> (svn_ra_dav__open): Get proxy information from config. Note that
> the #ifdef'd print statements are left deliberately.
>
>* subversion/include/svn_config.h: Don't include svn_string.h
> anymore. Replace the syntax description with a pointer the new
> config README file, see new svn_config_ensure for more.
> (svn_config_get): Take valuep as `const char **' now. Document
>
Why? This way you throw away the known length of the string, for no benefit.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 20 02:23:35 2002

This is an archived mail posted to the Subversion Dev mailing list.