[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1560 - trunk/subversion/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-03-20 02:05:46 CET

gstein@tigris.org writes:
> Remove pool usage in status printing to prevent memory growth.
>
> * cmdline/status.c (print_long_format): remove pool argument, use a
> buffer for serializing the revision number, and revamp the logic
> for filling in and using the revision string.
> (svn_cl__print_status_list): don't pass a pool to print_long_format

Ooooh, nice. :-)

> + /* ### we shouldn't clip the revstr and author, but that implies a
> + ### variable length 'last_committed' which means an allocation,
> + ### which means a pool, ... */
> sprintf (last_committed, "%6.6s %8.8s ",
> - revstr ? revstr->data : " ? ",
> + revstr,
> s_author ? s_author->data : " ? ");

I don't think it's so bad. This output is supposed to line up in
columns anyway...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 20 01:57:29 2002

This is an archived mail posted to the Subversion Dev mailing list.