[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1529 - trunk/tools

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-03-19 22:53:33 CET

Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
> > > New Revision: 1529
> > >
> > > Modified:
> > > trunk/tools/enable-dupkeys.sh
> > > Log:
> > > 2002-03-15 Blair Zajac <blair@orcaware.com>
> > >
> > > * tools/enable-dupkeys.sh: On RedHat systems using RawHide
> > > db4-4.0.14-4, db_dump and db_load are named db4_dump and db4_load,
> > > respectively. Have the script look for db4_* and then db_*.
> >
> > This log message doesn't follow our standard format. Please review the
> > HACKING guide and the numerous existing log messages for the format that we
> > use.
> >
> > Specifically, that first line should go, as it is totally redundant (date,
> > author, email).
> >
> > Normally, we have an overview of the change, followed by the specific
> > changes to the files.
> >
> > Cheers,
> > -g
> >
> > --
> > Greg Stein, http://www.lyra.org/
>
> Blair, you can use
>
> http://svn.collab.net/scripts/tweak-log.cgi
>
> to rewrite the log message.
>
> -Karl

Greg, Karl,

Thanks. I've been using XEmacs C-X 4-a to generate the change logs. Is
there a way to modify it to not tab indent automatically?

I've updated the log message to

On RedHat using RawHide db4-4.0.14-4 and certain FreeBSD systems (as reported
by Ben Collins-Sussman), db_dump and db_load are named db4_dump and db4_load,
respectively. Have the script look for db4_* and then db_*.

* tools/enable-dupkeys.sh: Use db4_dump and db4_load if they exist. If not,
  use db_dump and db_load.

While we're reviewing log files, maybe we should update 1457 and 1474 to
follow the same guidelines :) The second log doesn't say which files were
modified.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 19 22:55:01 2002

This is an archived mail posted to the Subversion Dev mailing list.