[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1511 - trunk/subversion/include trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/libsvn_ra_dav

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-03-14 20:54:01 CET

On Thu, Mar 14, 2002 at 12:29:02PM -0600, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_ra.h Thu Mar 14 12:29:00 2002
>...
> @@ -233,22 +228,15 @@
> void *callback_baton,
> apr_pool_t *pool);
>
> - /* Retrieve a "working copy" property for an item relative to the
> - "root" of the session (defined by REPOS_URL to the open() vtable
> - function call).
> -
> - The baton passed to the get_wcprop callback is the CALLBACK_BATON.
> -
> - If it quite legal to set this field to NULL if the RA user cannot
> - support WC properties, or they are not defined/applicable for the
> - current session.
> -
> - ### we might have a problem if the RA layer ever wants a property
> - ### that corresponds to a different revision of the file than
> - ### what is in the WC. we'll cross that bridge one day...
> - */
> + /* Fetch working copy properties. */
> svn_ra_get_wc_prop_func_t get_wc_prop;

Woah! Why did you torch this comment? That removed all knowledge about
being legal to set that field to NULL.

I can see the info about "relative" and the baton is redundant with info
about the type (although the svn_ra_get_wc_prop_func_t doc needs to be
updated to remove refs to CLOSE_BATON).

This also removed the warning about retrieving props for a revision that
doesn't occur in the WC.

[ /me thinks of blowing away Ben's comment a couple weeks ago, too... ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 14 20:51:23 2002

This is an archived mail posted to the Subversion Dev mailing list.