[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1508 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby

From: <cmpilato_at_collab.net>
Date: 2002-03-14 16:22:57 CET

gstein@tigris.org writes:

> Log:
> Move a lot of public WC symbols into the private wc.h header
> file. These are all specific to how we store the .svn/entries file, so
> they really aren't part of the public API.

Hm ... an unfortunate side-effect of this change is that readers of
entry structures that live outside of the WC library now may only
examine the first-class citizen members of those structures.

For example, I have some code in libsvn_client now (in-progress) that
wants to know if an entry has copyfrom history. It *used* to get the
SVN_WC_ENTRY_ATTR_COPYFROM_URL item from the entry's hash (since
copyfrom_url is not a first-class entry citizen) ... but now that
#define'd hash key is hidden inside the WC library.

Two solutions:

1. (easy solution) Revert Greg's change.

2. (much more involved solution) Promote all entry members to
    first-class citizens, and in doing so, might I recommend losing
    the "attributes" hash that lives in the entry, too? That hash is
    a transient state between disk and structure, and need not be
    toted around everywhere we go. The day someone actually has
    custom entry things to track, a hash for ONLY those custom items
    can be re-added.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 14 16:25:52 2002

This is an archived mail posted to the Subversion Dev mailing list.