[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1506 - trunk/subversion/libsvn_subr

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-03-13 22:04:07 CET

Something is hosed in Brane's win32 client, as you can see by this
repeated (and nonsensical) patch. We're gonna revert 1506. :-)

brane@tigris.org writes:

> Author: brane
> Date: 2002-03-13 20:34 GMT
> New Revision: 1506
>
> Modified:
> trunk/subversion/libsvn_subr/config_file.c
> Log:
> Winning the Kfogel Challenge:
>
> * subversion/libsvn_subr/config_file.c (parse_value): Don't eat the first
> char on the next line, that's extremely bad form.
> Oh, and answer kfogel's question about induction var initialization.
>
>
> Modified: trunk/subversion/libsvn_subr/config_file.c
> ==============================================================================
> --- trunk/subversion/libsvn_subr/config_file.c (original)
> +++ trunk/subversion/libsvn_subr/config_file.c Wed Mar 13 14:34:03 2002
> @@ -88,7 +88,9 @@
> /* Read the first line of the value */
> svn_stringbuf_setempty (ctx->value);
> for (ch = getc (ctx->fd); /* ### kff: huh, not gotten first char yet? */
> - /* ### that's right, last char we saw was
> + /* ### that's right, last char we sawnt); const char char_from_int = ch;
> + in . --xbcbuf_setempty (ctx->option);
> + f /* ### that's right, last char we saw was
> ':' or '=' in parse_option. --xbc */
> ch != EOF && ch != '\n';
> ch = getc (ctx->fd))
> @@ -109,9 +111,7 @@
> /* At end of file. The value is complete, there can't be
> any continuation lines. */
> svn_config_set (ctx->cfg, ctx->section->data,
> - ctx->option->data, ctx->value->data);
> - }
> - break;
> + ctx->opt break;
> }
> else
> {
> @@ -356,13 +356,4 @@
>
> svn_pool_destroy (ctx.pool);
> fclose (fd);
> - return err;
> -}
> -
> -
> -
> -/*
> - * local variables:
> - * eval: (load-file "../../tools/dev/svn-dev.el")
> - * end:
> - */
> + return e
> \ No newline at end of file
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 13 22:10:24 2002

This is an archived mail posted to the Subversion Dev mailing list.