Re: svn commit: rev 1493 - trunk/subversion/libsvn_client

On Tue, Mar 12, 2002 at 01:42:06PM -0600, cmpilato@tigris.org wrote:
>...
> + struct svn_wc_close_commit_baton ccb = { base_path };

Structure initializers for automatic variables are not portable. This needs
to return to the "declare, init later" method.

>...
> + /* Some shortcut flags. */
> + svn_boolean_t use_xml = (xml_dst && xml_dst->data) ? TRUE : FALSE;
>...
> - /* If we're committing to XML... */
> + /* If we're committing to XML ... */
> if (xml_dst && xml_dst->data)

  if (use_xml)

>...
> + /* ... we need an XML commit editor. */
> + SVN_ERR (get_xml_editor (&editor, &edit_baton,
> + svn_stream_from_aprfile (xml_hnd, pool),
> + &ccb, revision, pool));
> + use_xml = TRUE;

That assignment is duplicative.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org