[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1485 - trunk/subversion/libsvn_subr trunk/subversion/clients/cmdline trunk/subversion/clients/cmdline/man

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-03-12 19:33:07 CET

On Tue, Mar 12, 2002 at 12:59:17AM -0500, Ben Collins wrote:
> On Tue, Mar 12, 2002 at 12:04:23AM -0500, Greg Hudson wrote:
> > On Mon, 2002-03-11 at 14:47, bcollins@tigris.org wrote:
> > > + /* If user passed '-', use stdin. We could use apr_file_open_stdin here, and
> > > + * in fact, it does work. Problem is that if the same command invokes the
> > > + * editor, stdin is crap, and the editor acts funny (if not die outright). I
> > > + * wanted to just disallow stdin reading and invoking the editor, but there's
> > > + * no easy callback for that right now. */
> >
> > It would also probably be reasonable, on Unix, to reopen /dev/tty as
> > stdin (and maybe also as stdout and stderr) on the child in this case.
>
> Yeah. Couldn't see a portable way to do this. Since I didn't see any
> other OS specific code, I didn't know what the consensus would be in
> this case.

Right. I'd say that if we're reading stdin for some targets, that we disable
the EDITOR functionality, which may (in turn) fail a commit-related action
unless --force is used.

For example, if they omit -F and -m, we normally go to pop up EDITOR to get
a message. If stdin is used, we disable that functionality. The result is
that a message isn't present, which is normally a failure. However, we allow
--force to get the commit to go in without a log message.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 12 19:30:47 2002

This is an archived mail posted to the Subversion Dev mailing list.