[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1485 - trunk/subversion/libsvn_subr trunk/subversion/clients/cmdline trunk/subversion/clients/cmdline/man

From: Ben Collins <bcollins_at_debian.org>
Date: 2002-03-11 23:45:43 CET

On Mon, Mar 11, 2002 at 02:29:57PM -0800, Greg Stein wrote:
> On Mon, Mar 11, 2002 at 01:47:35PM -0600, bcollins@tigris.org wrote:
> >...
> > +++ trunk/subversion/clients/cmdline/merge-cmd.c Mon Mar 11 13:47:35 2002
> > @@ -47,7 +47,7 @@
> >
> > options = svn_cl__stringlist_to_array (opt_state->extensions, pool);
> >
> > - targets = svn_cl__args_to_target_array (os, pool);
> > + targets = svn_cl__args_to_target_array (os, opt_state, pool);
> > svn_cl__push_implicit_dot_target (targets, pool);
> > SVN_ERR (svn_path_remove_redundancies (&condensed_targets,
> > targets,
>
> It would seem to make sense for us to call svn_cl__args_to_target_array() in
> the main code, and pass that to all the functions.
>
> Right now, we pass 'apr_getopt_t *os' everywhere, but that would be obviated
> by passing in the targets. Thus, every command gets an opt_state and a set
> of targets. Much cleaner, and independent of the getopt processing.

Makes sense to me aswell.

> >...
> > +++ trunk/subversion/clients/cmdline/main.c Mon Mar 11 13:47:35 2002
> > @@ -67,6 +67,7 @@
> > {"username", svn_cl__auth_username_opt, 1, "specify a username ARG"},
> > {"password", svn_cl__auth_password_opt, 1, "specify a password ARG"},
> > {"extensions", 'x', 1, "pass \"ARG\" as bundled options to GNU diff"},
> > + {"targets", 't', 1, "pass contents of file \"ARG\" as additional args"},
>
> It seemed that consensus said to not use a short name, but only the long
> --targets form.

Crap, I added the short _opt_t entry to cl.h, but forgot to change the
struct here to use it. I'll fix that.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/       Ben Collins    --    Debian GNU/Linux    --    WatchGuard.com      \
`          bcollins@debian.org   --   Ben.Collins@watchguard.com           '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 11 23:49:39 2002

This is an archived mail posted to the Subversion Dev mailing list.