[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1460

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2002-03-09 20:17:30 CET

On Fri, 8 Mar 2002 kfogel@tigris.org wrote:
> Stop creating a new subpool for each error, and clear all unreturned
> (i.e., locally handled) errors. Partially based on a patch from Ben
> Collins <bcollins@debian.org>.

This approach seems very dangerous. It works for the two things we
currently do to handle errors (ignore them, or pass them back to the
caller, perhaps annotated), but any more complicated recovery operations
must obey the terrible constraint that they must not call any routine
which might ignore an error in the process of its operation, or the error
being handled becomes invalid.

Allocating a separate pool for each error might seem costly because of the
8K minimum, but really, that space will be reclaimed pretty quickly no
matter what happens to the error.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 9 20:18:28 2002

This is an archived mail posted to the Subversion Dev mailing list.