Re: Updated [patch] new part 1 for log command

On Thu, Feb 28, 2002 at 08:43:49PM -0800, Greg Stein wrote:
> [ per IRC, there are still some problems in the svn_client_log() handling
> for URLs; Ben is going to redo that portion ]
>
> The patch looks good, but for the URL code in svn_client_log. I'd recommend
> returning SVN_ERR_UNSUPPORTED_FEATURE for that for now, and we'll get the
> rest of this in. The URL can be done in a second round. Thoughts?

Here's the new patch. I've implemented the suggestions (qsort, then
remove dups in svn_fs_revisions_changed). I've left the URL in place.
However, only the "URL PATH ..." case works, so trying to pass a URL
alone returns an unsupported error. Fixed the calls to
svn_client__open_ra_session and svn_client__get_revision_number in the
case of passed URL. Here's the changelog:

        * libsvn_fs/tree.c(svn_fs_revisions_changed): Change to take an
        array of stringbuf's for paths instead of one path. It will then
        iterate to get a list of all revs for all paths (reduces amount
        of trails for getting info on multiple paths).

        * include/svn_fs.h: Updated decleration and comments for
        svn_fs_revisions_changed.

        * svnadmin/main.c(main): Updated use of svn_fs_revisions_changed
        for lscr.
        * tests/libsvn_fs/fs-test.c(revisions_changed): Likewise.

        * libsvn_subr/sorts.c(svn_sort_compare_revisions): New function
        for sorting an array of revisions.
        * include/svn_sorts.h: Declare it.

        * libsvn_repos/log.c(svn_repos_get_logs): Make use of newly
        modified svn_fs_revisions_changed. We pass it the paths passed
        to us (if any). The returned array of revs is then used to trim
        down the logs to just those that the caller is intersted in.

        * libsvn_client/log.c(svn_client_log): Enable the parsing and
        usage of complete URL's. For now, passing a URL alone is
        unsupported. User must pass a URL plus paths.

        * cmdline/main.c: Update usage info for log command. Also, allow
        -D option for logs. This works with ra_local, but ra_dav doesn't
        have the required function yet.
        * man/svn.1(log): Update usage of log command.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/       Ben Collins    --    Debian GNU/Linux    --    WatchGuard.com      \
`          bcollins@debian.org   --   Ben.Collins@watchguard.com           '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org