[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] partial fix for issue 571

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-02-26 14:27:49 CET

On Mon, Feb 25, 2002 at 09:56:13PM -0500, Garrett Rooney wrote:
> On Mon, Feb 25, 2002 at 05:59:47PM -0800, Greg Stein wrote:
> > [ most of this mentioned over IRC to Garrett, but he asked for it to be sent
> > to the list, so others can get the info, too :-) ]
> and here's the new version of the patch, with gstein's comments taken
> into account. note that it has one small problem, but i don't think
> it's with this patch. we never print out 'Replaced (bin)', since when
> we replace something, even if it is binary (and the svn add showed it
> was binary) when we see it in close_file() it never has the binary
> flag set on it. i haven't had a chance to debug this yet though, so
> if someone wants to take a look, feel free.
> again, if there are no more comments, i will commit today or tomorrow.
> even with the bug, it gets us closer to the desired functionality, and
> doesn't seem to hurt anything.

I just committed this in rev 1378, with one change. In a moment of
paranoia, I added a check to delete_entry to see if the entry is
already in the hash table and if so update it's status there if it is,
rather than overwriting it. This doesn't seem to happen (we always
seem to get add called, then delete, never the other way around), but
I couldn't find any documentation telling me it was garunteed to work
this way, so I figured better safe than sorry.

Next, on to trace-update.c, which seems like it will need to change to
look quite a bit more like trace-commit.c, since it will need to grow
ref counts to tell when the directory should be printed out.


garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.