Re: [PATCH] Turn on deflate in the client

On Tue, Feb 26, 2002 at 12:33:19AM +0000, Joe Orton wrote:
> On Tue, Feb 19, 2002 at 04:11:40PM -0800, Greg Stein wrote:
>...
> > Why the test for NEON_ZLIB ? I seem to recall glancing through the Neon code
> > and seeing that the compress stuff is just a simple passthrough when the
> > zlib stuff isn't around.
>
> No, currently the ne_compress_* API isn't built or linked in if zlib
> wasn't found.

Ah.

> > But if not, then Neon is broken :-) ... it should have a single, binary API
> > that we can dynamically use (or test) for the compression stuff. Otherwise,
> > you could build against one Neon, and use another that does (not) have the
> > zlib stuff.
>
> ... but I can do this for a future version.

Cool! That would be great.

We've taken the same tack in APR and SVN: the libraries export a constant
set of symbols so that if you build against one thing, but link against
another, then you're still fine. Functionality might change, but you aren't
going to die at link/load time.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org