[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] partial fix for issue 571

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-02-25 20:21:23 CET

On Mon, Feb 25, 2002 at 07:21:13PM +0100, Branko _ibej wrote:

[ snip much code and comments ]

> Right here. It you add 'fb', keyed off it's name, to the hash instead of
> the binary/text flag, you can later: a) check fb->binary directly
> instead of muching around with the enums; b) fix up 'added' to
> 'replaced', as I suggested above.
>
> This may mean a bit more work up front, but the code would definitely be
> cleaner. Not to mention that you'd have only one additional hash table
> instead of two.

I can't believe I didn't think of that... It will certainly make
things much simpler. I'll write this change up tonight.

Thanks,

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.