[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subpool not properly destroyed in svnlook/main.c::print_ids_tree()

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-02-23 17:10:08 CET

On Sat, Feb 23, 2002 at 03:14:30PM +0100, Lele Gaifax wrote:
> While browsing the source, I faced what seems an obvious typo: in the
> function print_ids_tree(), there is a double pool_create(), instead of
> the usual pool_create()/pool_destroy():
> /* Recursively handle the node's children. */
> subpool = svn_pool_create (pool);
> ...
> while (tmp_node->sibling)
> {
> ...
> }
> svn_pool_create (subpool);
> return;

and if you look closer, you'll see that the subpool isn't even being
used for anything... i think it should be being passed into
everything from where it's created to right before the return... have
to read a bit more of the code first though.

thanks for pointing this out.


garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.