Re: svn commit: rev 1351 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

On Thu, Feb 21, 2002 at 04:45:40PM -0600, Karl Fogel wrote:
>...
> ... but svn_diff_cmd_t is also mainly a client/WC thing, as per your
> comments on the property stuff.

I'm unclear on why it didn't stay in the WC. ??? Or if it is from the "diff
editor" then maybe svn_delta.h. And lastly, just how related is this to the
diff I/O? (svn_io.h)

Maybe it does belong in svn_types, but it just doesn't "feel" right. I'm not
terribly fussed about this particular thing, but the overall "pig pile" into
svn_types.h

> In general, it seems that header files always end up posing a few
> weird categorization problems. C is a programming language, not an
> ontology system. Of our existing headers, I can't think of any that's
> more appropriate for svn_diff_cmd_t than svn_types.h. If we *were*
> going to create a new header, I'm not sure what else it would hold
> besides svn_diff_cmd_t, or if it did hold other stuff as well, I don't
> see how we would avoid still feeling that something had been
> miscategorized. :-)

true :-)

> All that said, if you can think of a new header that makes more sense,
> by all means create it. I agree svn_types.h is a bit of a grab bag,
> it's just that no better dividing line is jumping out at me right
> now... "svn_subr.h" is pretty non-specific, and an abstract function
> type isn't even really a subr anyway, if we're being picky.
> Meanwhile, svn_io.h is about io, diff stuff seems as out-of-place
> there as anywhere.

Okay... looking at the typedef, I can see that it doesn't belong in IO. But
still not clear on the move from WC.

> Maybe we should just wallow in a permanent state of sin and have
> "svn-grab-bag.h"?

hehe... svn_kitchen_sink.h :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org