Re: svn commit: rev 1329 - trunk/subversion/svnadmin trunk/subversion/tests/clients/cmdline

Karl Fogel wrote:
>
> Blair Zajac <blair@orcaware.com> writes:
> > I'm doing some refactoring of code from cl.h into svn_getopt.h. It
> > would be handy if svn could do diffs that include file copies and
> > renames, much like what arch does. Otherwise it's harder to send
> > a patch in and keep the history.
>
> For now, you can just accompany the patch with human-readable
> instructions about renames (agree that better support would be good,
> and someday we'll have it). Your patch sounds interesting, want to
> say more?

As Greg mentioned, just to pull those program independent pieces that
do getopt processing in cl.h and clients/cmdline/main.c out and create
two new files, svn_getopt.h and svn_getopt.c. svnadmin/main.c's
currently uses a large switch to decide what to do. However, cmdline/main.c
supports a function call interface, so I'll break out the switch case
statements into separate functions.

The only problem I see is that table (array of structs) that contains
the function pointers to call takes a svn_cl__opt_state_t, which is
specific to cmdline/main.c and won't work with svnadmin/main.c. I'll
change this to a void * pointer and the functions can cast those back.

I was going to put svn_getopt.c into ./subversion/libsvn_subr. Is this
the appropriate place for it?

Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org