[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in cmdline/main.c::parse_date(), with fix

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-02-21 06:06:18 CET

Lele Gaifax <lele@seldati.it> writes:
> The function bombs when given any word not recognized by
> revision_from_word(). When the argument to '-D' does not contain a ':'
> char, the function sets `right_date' to NULL, then checks if the
> parameter is a know "keyword", then it does a "if (*right_date)" that
> is evidently wrong, and the intention was surely to do a "if
> (right_date)", without deferring it.
> I'm just starting looking around with svn, and I'm not yet up to
> providing a proper patch, since I'm still learning the svn
> way-of-doing. My apologies if this is not the right forum.

Thanks for the bug report! That code hasn't been tested much yet, and
surely needs exercising and examination.

If you spotted a bug, yet don't feel comfortable posting a patch
because you're afraid it won't be in proper SVN style or something,
then we've been doing something wrong here. You should feel
comfortable submitting the patch, and if any corrections are
necessary, the reviewer(s) will, we hope, point them out in as
constructive and friendly a manner as possible.

The best way to learn "the svn way-of-doing" is to get your patches
reviewed, early and often. So please post! :-)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.