[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Turn on deflate in the client

From: Sander Striker <striker_at_apache.org>
Date: 2002-02-14 23:21:01 CET

> From: Joe Orton [mailto:joe@manyfish.co.uk]
> Sent: 14 February 2002 22:26

> On Thu, Feb 14, 2002 at 08:43:53PM +0100, Sander Striker wrote:
> > Hi,
> >
> > This patch gave me the following error on a server with mod_deflate enabled:
> >
> > A trunk/subversion/tests/libsvn_fs/fs-test.c
> >
> > subversion/libsvn_ra_dav/fetch.c:1044
> > svn_error: #21082 : <RA layer request failed>
> > could not checkout a file
> >
> > subversion/libsvn_ra_dav/util.c:77
> > svn_error: #21082 : <RA layer request failed>
> > fetching a file: Could not read response body: connection was closed by server.
>
> Ah, on second thoughts, it seems a little unnecessary to be compressing
> the OPTIONS response too; i.e. patch fetch.c but not util.c (for the
> moment anyway).
>
> joe

Even without it, it fails at the same point.

Sander

PS. I patched mod_deflate for this:

Index: modules/experimental/mod_deflate.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/experimental/mod_deflate.c,v
retrieving revision 1.2
diff -u -r1.2 mod_deflate.c
--- modules/experimental/mod_deflate.c 8 Dec 2001 13:05:56 -0000 1.2
+++ modules/experimental/mod_deflate.c 14 Feb 2002 22:16:12 -0000
@@ -235,6 +235,10 @@
             return ap_pass_brigade(f->next, bb);
         }

+/* These checks go against the spec. Just BrowserMatch for
+ * the troublesome clients.
+ */
+#if 0
         /* GETs only (for the moment) */
         if (r->method_number != M_GET) {
             return ap_pass_brigade(f->next, bb);
@@ -244,6 +248,7 @@
         if (strncmp(r->content_type, "text/html", 9)) {
             return ap_pass_brigade(f->next, bb);
         }
+#endif

         /* some browsers might have problems, so set no-gzip
          * (with browsermatch) for them */

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:08 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.