Re: Um, why do we strip the SVNDIFF header for local writing

Daniel Berlin <dan@dberlin.org> writes:
> It seems to make more sense to put it in the rep. The rep is what
> tells us it's svndiff format, not the data.
> Thus it makes sense for the rep to tell us *which version* of svndiff
> format it is.
> The version is certainly not a property of the data.

Yah, I think so too.

It may be possible to do this in a backwards compatible way. The data
portion of a delta representation looks like:

   (("delta" ...) (OFFSET WINDOW) ...)
       Each OFFSET indicates the point in the fulltext that this
       element reconstructs, and WINDOW says how to reconstruct it:

       WINDOW ::= (DIFF SIZE CHECKSUM [REP-KEY [REP-OFFSET]]) ;
       DIFF ::= ("svndiff" STRING-KEY)
       [...]

If we put the svndiff version number in the DIFF element (say, as a
list skel before STRING-KEY) then its absence can mean Version 0. It
might be cleaner just to always require it, though, and make this part
of the general repository cleanup.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006