[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1273 - trunk/subversion/libsvn_ra_dav

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-02-14 17:29:56 CET

kevin@tigris.org writes:
> Partially fix Issue 624. See the issue for details.
>
> * subversion/libsvn_ra_dav/fetch.c (fetch_dirents): take a recurse parameter,
> only PUSH_SUBDIRS if it is true.
>
> (svn_ra_dav__do_checkout): Pass recurse parameter down to fetch_dirents.
> Continue looping until sentinel is reached to ensure that close_directory is
> called on the directory.
>
>
> Modified: trunk/subversion/libsvn_ra_dav/fetch.c
> ==============================================================================
> --- OLD/trunk/subversion/libsvn_ra_dav/fetch.c Thu Feb 14 09:23:32 2002
> +++ NEW/trunk/subversion/libsvn_ra_dav/fetch.c Thu Feb 14 09:23:32 2002
> @@ -343,6 +343,7 @@
> static svn_error_t * fetch_dirents(svn_ra_session_t *ras,
> const char *url,
> void *dir_baton,
> + svn_boolean_t recurse,
> apr_array_header_t *subdirs,
> apr_array_header_t *files,
> prop_setter_t setter,
> @@ -402,12 +403,15 @@
> }
> else
> {
> - subdir_t *subdir = apr_palloc(pool, sizeof(*subdir));
> + if (recurse)
> + {
> + subdir_t *subdir = apr_palloc(pool, sizeof(*subdir));
> [...]

Any reason not to fold this into one "else if (recurse)"? Is there a
future `else' case planned for the "if (recurse)"?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.