Re: svn commit: rev 1267 - trunk/subversion/include trunk/subversion/libsvn_subr

On Wed, Feb 13, 2002 at 04:45:14PM -0600, brane@tigris.org wrote:
>...
> +/* XXX FIXME: These should be protected by a thread mutex.
> + svn_error__locate and make_error_internal should cooperate
> + in locking and unlocking it. */
> +static const char *error_file = NULL;
> +static long error_line = -1;
> +void
> +svn_error__locate (const char *file, long line)
> +{
> +#ifdef SVN_DEBUG
> + /* XXX TODO: Lock mutex here */
> + error_file = file;
> + error_line = line;
> +#endif
> +}

Woah!

Why don't we just pass these values into the functions. I'd *much* prefer
that over this global variable hackage...

The createf() thing?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org