Re: [PATCH]: Revised cvs2svn.py patches

On Tue, Feb 12, 2002 at 08:02:40AM -0500, Daniel Berlin wrote:
>...
> > That just
> > seems weird; like it is a total disregard of interfacing with existing
> > software(!).
>
> Don't look so surprised. iostreams = good, stdio = bad, remember?

Wow. stdio is implemented and optimized across the planet, and the C++ guys
go and start all over... :-)

>...
> > Hmm. Well, if we can't portably convert a FILE* or file descriptor into a
> > stream, then we can certainly remove that capability. I'd like to keep the
> > general ability of passing a file object.

[ to clarify: keep the ability in the generic interface; have tparse punt on
  a Python file object ]

> So would I.
> In fact, this completely took me by surprise when i tried to compile
> tparse with g++ 3.
>
> Attempts to find a solution have been generally met with "Just use
> ifstreams". E

All right. Well, we can just rip that functionality out of tparse. Since we
aren't using 'configure' for it, then we can't really figure out the right
solution.

>...
> > Huh? If there are different authors, then how could it possibly be the same
> > commit?
>
> By abusing the way you digest.
> (Sorry, that just sounds funny to me.)

Heh :-) .... okay, so it was due to a bug, not something about CVS.

>...
> > > Think what happens when we wind up with the case of two
> > > revisions to the same file in one commit.
>...
> > Oh. Hmm... does this happen if you commit to multiple branches at one time?
>
> Yes.

Okay. Well... since we will be punting branches right now, then we shouldn't
see this. But when I put in the "same file, more than once," then I'll limit
the test to include "on the same branch."

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org