Re: [PATCH] Win32 File Permission Fixes

"Jay Freeman \(saurik\)" <saurik@saurik.com> writes:

> (svn_io_set_file_read_write): Implemented a new function that removes
> the read-only flag from the specified file using apr_file_attrs_set().

Perhaps svn_io_set_file_read_only and svn_io_set_file_read_write
should be combined into a single function that takes a boolean
parameter. I can't decide if that's an improvement or not. A single
function is a better map onto APR, on the other hand if Subversion
always knows what change it is making there is no real benefit.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org