Re: svn_wc_status() unversioned semantics for non-wc files

Jay Freeman (saurik) wrote:

>Branko:
>
>OK, I might have misinterpreted your previous comment that APR deals
>with this, but the fix was to call svn_path_internal_style() from my
>code before passing the path to Subversion.
>
Well, that rocks!

>I've left the remainder of this e-mail just for kicks:
>
>========== OLD ===========
>
>OK, you know what... the specific errors I was looking at were supposed
>to be errors :). The calls are still incorrect, however.
>
>If you want to skip to the corrected analysis, skip down to the
><HERE!!!>.
>
>Here is what I'm seeing.
>
>I get a failure in apr_file_open() when it calls CreateFile().
>The error is ERROR_PATH_NOT_FOUND.
>
>apr_file_open() is being passed:
>"D:\Code\ninetjer\external\subversion\.svn/.svn/README"
>
>open_adm_file() is being passed:
>"D:\Code\ninetjer\external\subversion\.svn" and "README"
>and using v_extend_with_adm_name() to add "/.svn/README"
>
>Back through svn_wc__open_adm_file() to svn_wc_check_wc().
>
>When svn_wc_check_wc() gets this error, it assumes the entire deal isn't
>a working copy.
>
>Here is where I made my mistake. I'm looking at a call that
>legitimately isn't a working copy. However, CreateFile() shouldn't have
>been passed '/' even regardless.
>
><HERE!!!>
>
>When you pass in a legitimate file (directories work), Subversion goes
>through this process and tries to open:
>
>"./.svn/README"
>
>OK, here open_adm_file() is being passed ".". So is svn_wc_check_wc().
>
>Here is where it gets interesting: svn_wc_entry() is being passed:
>
>"D:\Code\ninetjer\external\subversion\BUGS"
>
>It calls svn_path_split() to get:
>
>Basename: "D:\Code\ninetjer\external\subversion\BUGS"
>Dir: ""
>
>Which obviously isn't going to work. Likely it's assuming the usage of
>the internal path separator on that.
>
>========== END OLD ===========
>
>Sincerely,
>Jay Freeman (saurik)
>saurik@saurik.com
>
>-----Original Message-----
>From: Branko Cibej [mailto:brane@xbc.nu]
>Sent: Monday, February 11, 2002 2:46 PM
>To: Jay Freeman (saurik)
>Cc: dev@subversion.tigris.org
>Subject: Re: svn_wc_status() unversioned semantics for non-wc files
>
>Jay Freeman (saurik) wrote:
>
>>Seeing as all files, even versioned files, are showing up as
>>"unversioned" to me due to weird Win32 issues, I'm not going to be able
>>to do a patch for this currently :). (I believe it is the / vs. \
>>issue, Subversion insists on letting /'s get down through the APR
>>
>layer,
>
>>but even changing all of the /'s results in a filename that doesn't
>>exist, so maybe not.) I need to look more into that first.
>>
>Strange. I'm not seeing this problem. Certainly APR is supposed to
>handle /->\ conversion for us. I don't think that's really what's
>happening.
>
>BTW, when was the last time you updated svn? I did some hacks around
>rev. 1235 to make the trunk work on Win32.
>
>>Sincerely,
>>Jay Freeman (saurik)
>>saurik@saurik.com
>>
>

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org