Re: *sigh*, Windows file open \ vs. / problem

Jay Freeman (saurik) wrote:

>The issue states that there should be a "svn_path_to_internal()"... so
>
And there is.

>the client would be converting it's path from D:\Code\hello to
>D:/Code/hello? What about on platforms where : is a separator and / is
>legal in filenames? (like Mac OS 9, well, the first part, I'm only 50%
>sure of the second part, and we're just being lucky that / isn't valid
>on Win32). As far as I'm concerned, the API needs to be accepting the
>OS's path separators at all points. Oh, wait, I'm seeing it now: the
>problem with URLs...
>
Look at the code. There's a monster in the dungeon whose name is
SVN_PATH_LOCAL_SEPARATOR, and its value is different on every system.

(O.K., just the one parameter isn't enough to handle Mac (pre OS X) or
VMS paths, but we'll burn that bridge when we come to it -- hopefully
after 1.0.)

>OK, now that I've said that, is that paragraph supposed to be placed in
>the issue file instead of to the mailing list? :) (I'm not quite sure
>about how that is supposed to happen yet.)
>
>Sincerely,
>Jay Freeman (saurik)
>saurik@saurik.com
>
>-----Original Message-----
>From: Branko Cibej [mailto:brane@xbc.nu]
>Sent: Monday, February 11, 2002 12:22 PM
>To: Jay Freeman (saurik)
>Cc: dev@subversion.tigris.org
>Subject: Re: *sigh*, Windows file open \ vs. / problem
>
>Jay Freeman (saurik) wrote:
>
>>*sigh*.... I have no idea what code is responsible for dealing with /
>>vs. \, but it definitely isn't being done :). It doesn't seem like APR
>>is dealing with it, and ends up trying to pass this mess to
>>CreateFile():
>>
>>D:\Code\ninetjer\external\subversion\.svn/.svn/README
>>
>>Isn't that wrong anyway? Even if you converted the \'s correctly it
>>wouldn't be pointing to the right place. Is this my fault? Was I
>>supposed to do conversion before passing it to the API? Even then, I
>>would assume that somewhere it would be converting _back_ before
>>
>handing
>
>>it to CreateFile() (either in APR or in Subversion somewhere). Well,
>>
>it
>
>>is this problem that is causing my problem with files showing up as
>>unversioned even when they are supposed to be marked normal.
>>
>Ah. Right now, Subversion doesn't accept \ as the separator on Windows,
>only /. We used to have that feature, but it was implemented so horribly
>
>that we threw it out, but didn't replace it with something better (yet).
>
>Look at issue #603, and related #684; it's one of the myriad things I
>haven't yet got around to. If you'd care to take on this one, I'd be
>eternally grateful!
>

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org