DOINK!! You're going to need to fix APR then, too. I screwed up the
same way in apr_file_attrs_set :). (OK, sent this e-mail a few minutes
too late, you already found it, hehe). BTW, if you note, the code for
svn_io_set_file_read_write is identical to svn_io_set_file_read_only
except only is changed to write, |= is changed to the incorrect &= !,
and maybe one other change in a comment. That large comment you seem to
be responding to has been there for a while in the other function, hehe.
I'll put together a new version of this patch tonight that addresses
your comments.
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
-----Original Message-----
From: Branko Cibej [mailto:brane@xbc.nu]
Sent: Monday, February 11, 2002 1:41 PM
To: Jay Freeman (saurik)
Cc: dev@subversion.tigris.org
Subject: Re: [PATCH] Win32 File Permission Fixes
...
>
>+
>+ attributes &= !APR_FILE_ATTR_READONLY;
>
Nope: you want "attributes &= ~APTR_FILE_ATTR_READONLY". Well, actually
you want the changed signature, but failing that, 1's complement is
surely better than logical negation. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006