Jay Freeman (saurik) wrote:
>Philip:
>
>(first second quoted comment) OK, I assumed the comments were talking
>about Subversion, not APR.
>
>(then back to the first) *sigh*... that's an interesting point. The
>most straightforward way to do that would be to call another APR
>function to see if the file exists first.
>
No need. apr_file_attrs_set will return an appropriate error code if the
file doesn't exist. You only have to check that, so that
svn_io_make_file_writable doesn't choke on that code.
> But, due to the... I don't
>even know what to call it... strategy? that APR is taking to Unicode,
>that would mean that the filename would get copied from multi-byte to
>Unicode yet _another_ time on OS's that purport to have a "Unicode FS"
>(whatever they mean by that, note it isn't "Unicode API").
>
>*winces in pain*
>
>*hates APR's file API and tries to avoid it like the plague*
>
>Sincerely,
>Jay Freeman (saurik)
>saurik@saurik.com
>
>-----Original Message-----
>From: Philip Martin [mailto:philip@codematters.co.uk]
>Sent: Sunday, February 10, 2002 5:19 PM
>To: dev@subversion.tigris.org
>Subject: Re: Windows build severly broken due to read-only issues...
>
>...
>
>Sounds good to me. Depending on what happens to apr_file_copy it may
>be that Unix also needs to make the destination writeable before
>copying. Will you check for the file's existance before setting the
>attributes?
>
>...
>
>I subsequently did write and post an APR patch to do this on Unix, see
>http://subversion.tigris.org/servlets/ReadMsg?msgId=57054&listName=dev
>
>...
>
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006