> From: Karl Fogel [mailto:kfogel@newton.ch.collab.net]
>
> Bill,
>
> Whew! I've applied your cancellation editor patch, sorry for the long
> delay.
There's nothing to be sorry about. I haven't found time to get around to
committing it myself. Thanks for doing it for me. :)
> Regarding your other two patches, which moved the trace
> editors into libsvn_client and then changed the client to use them
> there, I have some thoughts on an easier/more natural way to do it,
> given the current code base:
>
> Let's take advantage of the new user feedback types, by doing this
> (probably in two separate changes?):
>
> - move `svn_wc_notify_action_t' and `svn_wc_notify_func_t' to
> svn_types.h (they become svn_notify_action_t and
> svn_notify_func_t or whatever).
>
> - add a new action to `svn_notify_action_t', call it
> svn_notify_update (or svn_notify_modify, or whatever). I think
> we only need one new action, is that right?
>
Nope, that's wrong. :) The actions are missing property change specific
actions, and it also doesn't include file and property conflict
notifications. Enough action types have to be created so the function
that gets called can reproduce the existing formatting exactly.
I don't know when I'd be able to get around to doing it though. :(
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006