Re: [PATCH] if ! is not portable

On Sat, Feb 09, 2002 at 07:21:10PM +0100, Sander Striker wrote:
> > From: Blair Zajac [mailto:blair@orcaware.com]
> > Sent: 09 February 2002 18:42
>
> > Sander Striker wrote:
> > > I would suggest:
> > >
> > >
> > >
> > > instead.
> >
> > Except this passes cmp -s .... to test, which doesn't execute cmp.
>
> /me asking stupid questions...
>
> What about:
>
> if [ ! `cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4` ]; then

cmp -s produces no output, so this reduces to

if [ ! ]

which is a run-time syntax error.

The only other portable way to do this is

cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4
if [ $? -ne 0 ]; then

I don't see what was wrong with

if cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4
then :
else

it's a common idiom.

zw

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006