Re: svn commit: rev 1211 - trunk/subversion/libsvn_subr trunk/subversion/tests/libsvn_subr

Greg Stein <gstein@lyra.org> writes:

> On Thu, Feb 07, 2002 at 08:44:23PM -0600, philip@tigris.org wrote:
> >...
> > + apr_err = apr_file_name_get (&fname, file);
> > + if (!APR_STATUS_IS_SUCCESS(apr_err))
> > + return svn_error_create
> > + (apr_err, 0, NULL, pool,
> > + "svn_string_from_aprfile: failed to get filename");
> > +
> > + apr_err = apr_stat (&finfo, fname, APR_FINFO_SIZE, pool);
> > + if (!APR_STATUS_IS_SUCCESS(apr_err))
> > + return svn_error_createf
> > + (apr_err, 0, NULL, pool,
> > + "svn_string_from_aprfile: failed to stat '%s'", fname);
>
> This can be simplified by using apr_file_info_get().

Possibly, but then I would either have to call apr_file_name_get for
every subsequent error message, or not put the file name in the error
messages.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org