[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1214 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-02-08 05:31:39 CET

fitz@tigris.org writes:
> Modified:
> trunk/subversion/include/svn_wc.h
> trunk/subversion/libsvn_client/status.c
> trunk/subversion/libsvn_wc/status.c
> Log:
> This fixes bite-sized task number 598 ("svn status <nonexistent-file>"
> fails to give an error). Passes the stat_test.py test just fine.

Thanks, Fitz!

Quick question: did you mean to say "Passes the stat_test.py tests
just fine.", i.e., "tests" plural?

I mistakenly inferred that there was a specific test for this
until-now incorrect behavior, and that the test had been failing (and
was presumably commented out or not invoked, therefore), but now it
passes. There was no mention of stat_test.py in your change,
though... so poked around in stat_test.py... No, I don't see any test
which tests this particular problem.

Should we just change the log message to say

   "Passes stat_test.py just fine."

to avoid any ambiguity?

(Of course, if you want to *write* a specific test for this, that's
another matter. But hardly necessary, and you may have other fish to
fry... :-) .)


> * subversion/include/svn_wc.h
> (svn_wc_statuses): Added 'svn_boolean_t strict' parameter
> * subversion/libsvn_wc/status.c
> (assemble_status): Added 'svn_boolean_t strict' parameter. When
> strict is non-zero, return an error if we encounter a path that is not
> in the working copy.
> (add_status_structure): Added 'svn_boolean_t strict'
> parameter. Added 'strict' argument to all calls to assemble_status
> within.
> (add_unversioned_items): Added FALSE argument to call to assemble_status.
> (svn_wc_status): Added FALSE argument to call to assemble_status.
> (svn_wc_statuses): Added 'svn_boolean_t strict' parameter. Added
> 'strict' argument to all calls to assemble_status within. Also did
> some reformatting to keep within 80 cols.
> * subversion/libsvn_client/status.c
> (svn_client_status): Add strict var which is set to TRUE if we're
> not updating, and FALSE if we are updating. This allows us to properly
> error out if someone tries to stat a file that doesn't exist in the
> working copy. Added 'strict' argument to assemble_status invocation.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:05 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.