Re: Trace and cancel update patches part 3

Bill,

Whew! I've applied your cancellation editor patch, sorry for the long
delay. Regarding your other two patches, which moved the trace
editors into libsvn_client and then changed the client to use them
there, I have some thoughts on an easier/more natural way to do it,
given the current code base:

Let's take advantage of the new user feedback types, by doing this
(probably in two separate changes?):

   - move `svn_wc_notify_action_t' and `svn_wc_notify_func_t' to
     svn_types.h (they become svn_notify_action_t and
     svn_notify_func_t or whatever).

   - add a new action to `svn_notify_action_t', call it
     svn_notify_update (or svn_notify_modify, or whatever). I think
     we only need one new action, is that right?

   - Move the trace editors into libsvn_client, such that these two
     new functions

       svn_client_get_update_trace_editor()
       svn_client_get_commit_trace_editor()

     both take a svn_notify_func_t and baton in their args, and the
     returned editor simply invokes that function with the appropriate
     action type and path.

   - In command line client, make an instance of svn_notify_func_t()
     that does the printing part of what the current trace editors
     do, and fetch the editors with it.

Up for it? :-)

Comments anyone?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:05 2006