Re: [PATCH] cmdline/commit-cmd.c

Daniel Stenberg <daniel@haxx.se> writes:

> + /* BEGIN Client errors */
> +
> + SVN_ERRDEF (SVN_ERR_CMDLINE__FAILED_WRITING_TO_TEMPORARY_FILE,
> + "Failed writing to temporary file.")
> +
> + SVN_ERRDEF (SVN_ERR_CMDLINE__FAILED_STAT_ON_TEMPORARY_FILE,
> + "Failed getting info about temporary file.")
> +
> + SVN_ERRDEF (SVN_ERR_CMDLINE__FAILED_OPENING_TEMPORARY_FILE,
> + "Failed opening temporary file.")
> +
> + SVN_ERRDEF (SVN_ERR_CMDLINE__FAILED_READING_TEMPORARY_FILE,
> + "Failed reading temporary file.")
> +
> + /* END Client errors */

My gosh, man. Could you think of longer names please? These still
fit in 80 columns. :-)

Seriously, how about:

   SVN_ERR_CMDLINE__TMPFILE_WRITE
   SVN_ERR_CMDLINE__TMPFILE_STAT
   SVN_ERR_CMDLINE__TMPFILE_OPEN
   SVN_ERR_CMDLINE__TMPFILE_READ

?

[Note: I have not reviewed the rest of the patch -- silence does NOT
mean approval :-)]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:04 2006