[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

A question related to svn_io_run_cmd()

From: Daniel Stenberg <daniel_at_haxx.se>
Date: 2002-02-06 10:22:40 CET


With the 1189 commit, I could remove my system() kludge in the $EDITOR code
and use svn_io_run_cmd().

This ALMOST works the way I want now. And this is a question for feedback on
where we want the remaining problem fixed:

$ export EDITOR=vi (or EDITOR=emacs or EDITOR=echo)
$ svn ci

all work as assumed, but

$ export EDITOR="emacs -nw"
$ svn ci

does not. This way of setting the EDITOR variable works for most other
applications, including CVS and crontab etc why I argue SVN should support it

The reason for the malfunction is that I pass the full string "emacs -nw" as
CMD name to svn_io_run_cmd(), when it really should've been split up and the
"-nw" should've been placed in ARGS[1].

My question is, should I write the wrapper to handle this in commmit-cmd.c
for just the EDITOR functionality, or is this something we might need to make
a more generic approach for in svn_io_run_cmd() or a related function?

Other thoughts?

      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:04 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.