[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] --with-apr=/path/to/apr-config does not work

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-02-05 03:16:54 CET

If you try running Subversion's configure with
    ./configure --apr-path=/path/to/apr-config
then it won't take the apr-config because the current code in
ac-helpers/find_apr.m4 does this:

    if test -x "$withval/bin/apr-config"; then
      apr_found="yes"
      apr_config="$withval/bin/apr-config"
    elif test -f "$withval/libapr.la"; then
      apr_found="yes"
      apr_config="$withval/apr-config"
** elif test -x "$withval" -a "`$withval --help > /dev/null`"; then
      apr_found="yes"
      apr_config="$withval"
    fi

This test always fails. The patch checks for the successful running of
apr-config, not if there's output.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
Changelog log:
Make ./configure --apr-path=/path/to/apr-config work.
diff -ru ../svn/ac-helpers/find_apr.m4 ./ac-helpers/find_apr.m4
--- ../svn/ac-helpers/find_apr.m4	Mon Feb  4 15:36:04 2002
+++ ./ac-helpers/find_apr.m4	Mon Feb  4 17:58:40 2002
@@ -53,7 +53,7 @@
     elif test -f "$withval/libapr.la"; then
       apr_found="yes"
       apr_config="$withval/apr-config"
-    elif test -x "$withval" -a "`$withval --help > /dev/null`"; then
+    elif test -x "$withval" && $withval --help >/dev/null; then
       apr_found="yes"
       apr_config="$withval"
     fi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:04 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.