cmpilato@collab.net writes:
> > Perhaps first factor the predecessor calculation so that it's done in
> > exactly one place in the filesystem -- then having a special case in
> > it won't be so painful.
>
> Sorry, I should have explained that a little better. There is an
> svn_fs_predecessor_id() function, for operations that need to fly
> backward in node-Id ancestry, it's ridiculous to be allocating each
> predecessor from the pool when the simple calculation can be done
> in-place (using once-alloced memory).
Sorry. I should have explained my explanation better.
svn_fs_predecessor_id (my_id, pool) will return the predecessor ID of my_id,
allocated in pool. But there are at least two places in the code
where we are flying backward through all predecessors, and that
calculation is most efficiently done by modifying a single copy of
my_id in-place rather than allocating from pool which each iteration.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:04 2006