Re: svn commit: rev 1139 - trunk/subversion/include trunk/subversion/libsvn_client trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline

Greg Stein <gstein@lyra.org> writes:
> You're comparing for equality, not sort-ordering. Thus, you should be using
> strcasecmp() instead. APR will ensure that function's is prototyped/defined,
> presuming apr_general.h is included.

AAAAAAhhhhhhhhhhh.

Thank you.

I didn't see any apr_strcasecmp() in string.h, so I used
strnatcasecmp. But now I remember some earlier list discussion about
getting strcasecmp from APR, it just doesn't appear in apr_string.h
(sigh).

Changing now.

By the way, what does APR mean by a "natural" sort ordering? It has
the feeling of a technical term, but I don't really know how this
function is different from strcasecmp...

> >...
> > +valid_revision_number (const char *rev)
> > +{
> > + while (*rev) {
> > + if ((*rev < '0') || (*rev++ > '9'))
>
> #include <apr_lib.h>
>
> then use apr_isdigit()

Gotcha.

Thanks!

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:03 2006