[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: $EDITOR commit code cleanups

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-02-01 23:03:49 CET

Greg Stein <gstein@lyra.org> writes:
> For the *next* time you post the patch. I'd hate to see the patch submission
> process become so subject to rules and restrictions and other requirements
> that people get fed up and just go away. Suggestions to people on how to
> submit future patches "for the greater good" is a good thing, but (IMO) we
> should be careful about how hard we set the bar for (casual) patch
> contributors. If a person *is* a casual contributor, then onerous
> requirements will just send them away.
> The existing patch can still be reviewed, and should be. (will try soon)

Personally I find it very hard to review a patch without understanding
its goal, that's why I'd wait for the repost with the log msg. If you
want to review it as is, of course that's great!

I think asking for a repost w/ log msg hardly counts as "onerous" or
setting the bar too high. It should be (literally) 30 seconds or
less, assuming the submitter has all the data.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:03 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.