Re: [PATCH] issue 619 APR patch, issue 532 read-only admin

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Philip Martin <philip@codematters.co.uk> writes:
> > +#include "fileio.h"
> > +#include "apr_file_io.h"
> > +
> > +static apr_status_t
> > +apr_file_transfer_contents(const char *from_path,
> > + const char *to_path,
> > + apr_int32_t flags,
> > + apr_fileperms_t to_perms,
> > + apr_pool_t *pool)
>
> If it's static, it probably shouldn't have the "apr_" prefix. Would
> recommend a doc string however (I know APR isn't as strict about
> enforcing this as Subversion is, but that doesn't mean they don't like
> documentation too :-) ).
>
> I haven't looked carefully at the rest of the patch yet. Suggestion:
> since moving the apr_ functions over to APR is one change, and
> addressing Subversion issue #532 is a separate change, post one small
> patch for the former, and then post a second (dependent) patch for the
> latter.

Thats what you've got. The APR patch as posted is self contained,
there should be no need to change Subversion, to apply it. Once it's
applied the Subversion patch as posted will use it.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org