Re: A ton of new warnings on Win32

On Thu, Jan 31, 2002 at 12:06:12AM +0100, Branko �ibej wrote:
> I can't make out which commit produced these, so I'm dumping them here.
> They all stem from the fact that apr_off_t is 64-bit on Windows. We have
> to find a way to solve these problems in general, I think.

More things should be apr_off_t.

> C:\Home\brane\src\svn\repo\subversion\libsvn_fs\reps-strings.c(413) : warning C4244: 'function' : conversion from '__int64 ' to 'unsigned int ', possible loss of data

For example: in this one, rep_read_range() should take apr_off_t for the
offset.

Subversion should be able to store entities that have 64-bit sizes. I might
even argue that we should have "svn_fs_offset_t" which is apr_uint64_t. IOW,
the FS should use 64-bit sizes *independent* of what the operating system
considers is the max size for files.

On the client side, it will (of course) need to deal with platform max file
sizes. And the possibility that a file may come down the pipe which is
larger than it can store.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org